mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 46618: Enhanced the log message when there are duplicate volumes.
Date Mon, 25 Apr 2016 16:56:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46618/#review130445
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 300)
<https://reviews.apache.org/r/46618/#comment194186>

    Please remove the quote.



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 547)
<https://reviews.apache.org/r/46618/#comment194185>

    Quote is not needed for container id because it's generated by Mesos.


- Jie Yu


On April 25, 2016, 5:26 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46618/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 5:26 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added containerId to failure message when there are duplicate volumes
> in one container. Also quotaed the containerId in _cleanup.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 4675c767a562a3ca7f99265c9198a37786933c2d

> 
> Diff: https://reviews.apache.org/r/46618/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message