mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 45375: Implemented cleanup() for docker volume isolator.
Date Mon, 25 Apr 2016 00:26:09 GMT


> On 四月 24, 2016, 5:49 p.m., Gilbert Song wrote:
> > This patch looks good to me. Almost ship it! 
> > 
> > Just one concern:
> > 
> > Should we move the ref count logic out if we decide the future default behavior
without ref count? then, add ref count logic together with the agent flag in another patch.

Thanks Gilbert, I will update this part when we reach an agreement on the agent flag, we can
discuss in sync up meeting.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45375/#review130314
-----------------------------------------------------------


On 四月 24, 2016, 9:50 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45375/
> -----------------------------------------------------------
> 
> (Updated 四月 24, 2016, 9:50 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented cleanup() for docker volume isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp bedc687cc280d0b721fb84801039fd3614364cca

>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955

> 
> Diff: https://reviews.apache.org/r/45375/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message