mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 46610: Fix 'pivot_root is not available' error on ARM.
Date Sun, 24 Apr 2016 12:40:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46610/#review130303
-----------------------------------------------------------




src/linux/fs.cpp (line 442)
<https://reviews.apache.org/r/46610/#comment194017>

    Hi, @janisz, thank you very much for posting the patch. I think the root cause is we didn't
include the correct header.
    
    ```
    diff --git a/src/linux/fs.cpp b/src/linux/fs.cpp
    index 2087b4a..429105a 100644
    --- a/src/linux/fs.cpp
    +++ b/src/linux/fs.cpp
    @@ -19,6 +19,7 @@
     #include <string.h>
    
     #include <linux/limits.h>
    +#include <linux/unistd.h>
    
     #include <stout/adaptor.hpp>
     #include <stout/check.hpp>
    ``` 
    
    Could you change the patch like this? I verify it works on the Raspberry Pi just now.


- haosdent huang


On April 24, 2016, 11:36 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46610/
> -----------------------------------------------------------
> 
> (Updated April 24, 2016, 11:36 a.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix 'pivot_root is not available' error on ARM.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.cpp 2087b4ac1503e0fd085319b1017389f1f947536f 
> 
> Diff: https://reviews.apache.org/r/46610/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message