mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 45375: Implemented cleanup() for docker volume isolator.
Date Fri, 22 Apr 2016 08:11:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45375/#review130056
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 374)
<https://reviews.apache.org/r/45375/#comment193674>

    I saw you have already `using process::Owned` before?



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 375)
<https://reviews.apache.org/r/45375/#comment193675>

    How about reformat it like
    ```
      foreachvalue (process::Owned<Info> info, infos) {
        foreach (const DockerVolumeInfo& dockerVolumeInfo,
                 info->dockerVolumeInfos) {
          // The docker volume driver do not enable volume name or driver
          // include ":".
          const string volumeKey = dockerVolumeInfo.dockerVolume.driver() + ":" +
                                   dockerVolumeInfo.dockerVolume.name();
    ```



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 395)
<https://reviews.apache.org/r/45375/#comment193682>

    I suggest reformat this as well.



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 408)
<https://reviews.apache.org/r/45375/#comment193686>

    Actually the behaviour here a bit like `Counter` located in `./3rdparty/libprocess/include/process/metrics/counter.hpp`.
However `Counter` only used in metrics.



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 417)
<https://reviews.apache.org/r/45375/#comment193695>

    Seems concat them by `:` and split them by `:` eventually a bit not nice. Is it possible
that we use a `pair` as key type?



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 418)
<https://reviews.apache.org/r/45375/#comment193689>

    Add `CHECK_EQ(2, tokens.size())` here?


- haosdent huang


On April 22, 2016, 7:08 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45375/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 7:08 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented cleanup() for docker volume isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp bedc687cc280d0b721fb84801039fd3614364cca

>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955

> 
> Diff: https://reviews.apache.org/r/45375/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message