mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 45375: Implemented cleanup() for docker volume isolator.
Date Fri, 22 Apr 2016 07:00:43 GMT


> On 四月 22, 2016, 1:04 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines 378-380
> > <https://reviews.apache.org/r/45375/diff/4/?file=1354513#file1354513line378>
> >
> >     Seems like we should capture the first `:` here. Otherwise, we have to document
that users should not include any `:` in a volume name.

It is not valid to contain `:` in the volume name, the volume creation will be failed.

root@mesos002:~# dvdcli create --volumedriver=convoy --volumename=a:2
ERRO[0000] Invalid volume a:2. Must be only contains 0-9, a-z, dash(-), underscore(_) and
dot(.)  volumeName=a:2


> On 四月 22, 2016, 1:04 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, line 345
> > <https://reviews.apache.org/r/45375/diff/4/?file=1354513#file1354513line345>
> >
> >     add `!`.

good catch ;-)


> On 四月 22, 2016, 1:04 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines 399-408
> > <https://reviews.apache.org/r/45375/diff/4/?file=1354513#file1354513line399>
> >
> >     ditto.

I was following similar logic in https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/network/cni/cni.cpp#L671-L680
, I think that this can give end user a more clear message for all errors and is helpful to
trouble shooting, what do you think?


> On 四月 22, 2016, 1:04 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, line 420
> > <https://reviews.apache.org/r/45375/diff/4/?file=1354513#file1354513line420>
> >
> >     Will `container directory` be confused?

LOG(INFO) << "Removed the container docker volume checkpoint directory '"
          << containerDir << "'";


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45375/#review129968
-----------------------------------------------------------


On 四月 21, 2016, 3:43 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45375/
> -----------------------------------------------------------
> 
> (Updated 四月 21, 2016, 3:43 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented cleanup() for docker volume isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp bedc687cc280d0b721fb84801039fd3614364cca

>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955

> 
> Diff: https://reviews.apache.org/r/45375/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message