mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 46249: hook/module process operation before main process initialize.
Date Mon, 18 Apr 2016 01:15:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46249/#review129278
-----------------------------------------------------------




src/master/main.cpp (lines 195 - 196)
<https://reviews.apache.org/r/46249/#comment192748>

    Move this back to where it was. This needs to be called after `LIBPROCESS_*` environment
variables are set.
    
    Instead move the ModuleManager and HookManager initialization after `logging::initialize()`.


- Vinod Kone


On April 15, 2016, 8:09 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46249/
> -----------------------------------------------------------
> 
> (Updated April 15, 2016, 8:09 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If we in hook/module manager use libprocess library, it will auto use process initialize
fucntion, as the process::initialize will only call once,then in the main fucnton process
initialize  process::initialize("master") will not be called. So the HTTP request process
"delegate" will be wrong, http request will not be response.
> 
> 
> Diffs
> -----
> 
>   src/master/main.cpp ea7f0fc 
> 
> Diff: https://reviews.apache.org/r/46249/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message