mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 46191: Stout: Implemented `uname` on Windows.
Date Sun, 17 Apr 2016 22:45:10 GMT


> On April 15, 2016, 10:56 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 66
> > <https://reviews.apache.org/r/46191/diff/2/?file=1346314#file1346314line66>
> >
> >     `std::unique_ptr<T>` semantically means that it's pointing to a single
element. We should use  `std::unique_ptr<T[]>` to use the array of elements version.
We should also use `new` so that we don't have to manually calcaluate the number of bytes.
> >     
> >     ```
> >     std::unique_ptr<char[]> name(new char[size + 1]);
> >     ```

You're right, that is a lot cleaner, thanks!


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46191/#review129199
-----------------------------------------------------------


On April 15, 2016, 8:42 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46191/
> -----------------------------------------------------------
> 
> (Updated April 15, 2016, 8:42 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4470
>     https://issues.apache.org/jira/browse/MESOS-4470
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Implemented `uname` on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520

>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp edaa76a5322d0bf60b7172405aa754b5aca95458

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp c48106e5905e3be0faeba7177ef534766089faff

> 
> Diff: https://reviews.apache.org/r/46191/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message