mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.
Date Sun, 17 Apr 2016 21:59:38 GMT


> On April 15, 2016, 11:31 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 362
> > <https://reviews.apache.org/r/46013/diff/7/?file=1346286#file1346286line362>
> >
> >     What's the difference between `Failed to call X` vs `Call to `X` failed`?

Ah, I tried to be consistent about making all these messages say `Call to x failed` because
I thought it was clearer. That is why there are both -- I just didn't get all of them.

Also, this message is somewhat inconsistent with our style. We say `os::processes: Call to
x failed`. So we should fix that here too.


> On April 15, 2016, 11:31 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, lines 406-407
> > <https://reviews.apache.org/r/46013/diff/7/?file=1346286#file1346286line406>
> >
> >     I think it would easier to read:
> >     
> >     ```
> >     Try<Duration> utime = Nanoseconds(lKernelTime.QuadPart * 100);
> >     Try<Duration> stime = Nanoseconds(lUserTime.QuadPart * 100);
> >     ```
> >     
> >     This is also arguably more correct, since any number < 10,000,000 would incorrectly
result in 0 by the division.
> >     
> >     What do you think?

You're right, this was sloppy.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46013/#review129204
-----------------------------------------------------------


On April 15, 2016, 7:50 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46013/
> -----------------------------------------------------------
> 
> (Updated April 15, 2016, 7:50 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4471
>     https://issues.apache.org/jira/browse/MESOS-4471
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Implemented `os::processes` on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520

>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp edaa76a5322d0bf60b7172405aa754b5aca95458

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp c48106e5905e3be0faeba7177ef534766089faff

> 
> Diff: https://reviews.apache.org/r/46013/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message