mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 46254: Added a realm parameter to `process::initialize` (libprocess).
Date Fri, 15 Apr 2016 10:47:57 GMT


> On April 15, 2016, 12:35 p.m., Alexander Rojas wrote:
> > 3rdparty/libprocess/include/process/gtest.hpp, line 31
> > <https://reviews.apache.org/r/46254/diff/2/?file=1346267#file1346267line31>
> >
> >     Something tells me there should be a comment here, but I don't know exactly
what its contents should be.

I originaly thought this was in a cpp, but there are multiple problems I see:

1. We avoid ha static global strings since the have initialization uncertainty, also if something
goes wrong it can be destroy before you can use it.
2. The way to go is `constexpr char DEFAULT_HTTP_AUTHENTICATION_REALM[] = "libprocess-realm"`


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46254/#review129091
-----------------------------------------------------------


On April 15, 2016, 8:51 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46254/
> -----------------------------------------------------------
> 
> (Updated April 15, 2016, 8:51 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4902
>     https://issues.apache.org/jira/browse/MESOS-4902
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In order to enable authentication on libprocess-level
> HTTP endpoints, this patch adds a parameter to
> process::initialize which allows the authentication
> realm of such endpoints to be set when libprocess is
> initialized.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/gtest.hpp 3e0887257e1484813b3547170a5a1b9bb89de0d2

>   3rdparty/libprocess/include/process/process.hpp 77e96957ca556cf9a7e2bf427d6762572fe48c51

>   3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 
>   3rdparty/libprocess/src/tests/main.cpp 78858a2b84a439d8f8a60ec8bcb6ac3a308087a6 
> 
> Diff: https://reviews.apache.org/r/46254/diff/
> 
> 
> Testing
> -------
> 
> `sudo make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message