mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 46246: Log executor commands w/o verbose logs enabled.
Date Fri, 15 Apr 2016 05:22:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46246/#review129066
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46246]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 15, 2016, 2:30 a.m., Yong Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46246/
> -----------------------------------------------------------
> 
> (Updated April 15, 2016, 2:30 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joseph Wu.
> 
> 
> Bugs: MESOS-5197
>     https://issues.apache.org/jira/browse/MESOS-5197
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch changes the logging in docker.cpp from VLOG to
> LOG(INFO). The reason is that, the command line that has
> been executed by executor is useful in debug purposes.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 19cf424dfd5748ae66a7023840aa2b0652e8f2c0 
> 
> Diff: https://reviews.apache.org/r/46246/diff/
> 
> 
> Testing
> -------
> 
> make check (Ubuntu 14.04)
> 
> 
> Thanks,
> 
> Yong Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message