mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.
Date Fri, 15 Apr 2016 00:44:17 GMT


> On 四月 14, 2016, 10:55 p.m., Jie Yu wrote:
> > docs/configuration.md, line 1411
> > <https://reviews.apache.org/r/45326/diff/3/?file=1343835#file1343835line1411>
> >
> >     It's a directory or a file? Instead of doing that, can we just assume dvdcli
is in 'PATH' and add a check in DockerVolumeDriverClient::create?

OK, will try to use `os::which` to handle this. There is a JIRA tracing it: https://issues.apache.org/jira/browse/MESOS-4576
, will try to upload a patch for it.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45326/#review129022
-----------------------------------------------------------


On 四月 14, 2016, 6:06 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45326/
> -----------------------------------------------------------
> 
> (Updated 四月 14, 2016, 6:06 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5084
>     https://issues.apache.org/jira/browse/MESOS-5084
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added agent flag dvdcli_dir for specify dvdcli path.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md ce51f26f0584eeecb5c96e39a5bcc21f5906a29c 
>   src/slave/flags.hpp ee520acc459564fe68272950948fc80c5e24513a 
>   src/slave/flags.cpp 316feec26e52a8cb1f0fd0739176b3f502e1ed86 
> 
> Diff: https://reviews.apache.org/r/45326/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message