mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.
Date Thu, 14 Apr 2016 20:28:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40410/
-----------------------------------------------------------

(Updated April 14, 2016, 1:28 p.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Changes
-------

Reviving this chain...


Summary (updated)
-----------------

Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.


Bugs: MESOS-3934
    https://issues.apache.org/jira/browse/MESOS-3934


Repository: mesos


Description (updated)
-------

The metrics singleton must be unified with `process::initialize` so 
that it also falls under the scope of reinitialization.  The singleton 
must also not be guarded by `Once`.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/metrics/metrics.hpp 7abfadf6d030c52b7e03e773b67c74db6ad5b5df

  3rdparty/libprocess/src/metrics/metrics.cpp 7677dffed98153bc6276aad492a6815e67740ea3 
  3rdparty/libprocess/src/process.cpp afeddec20495bb9621c3e26b0d425c9419654739 
  3rdparty/libprocess/src/tests/system_tests.cpp 0f4d0424689522337806ba2227ec4330c700e17e


Diff: https://reviews.apache.org/r/40410/diff/


Testing
-------

Tests done in a subsequent review.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message