mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Naparu <alex.nap...@outlook.com>
Subject Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.
Date Wed, 13 Apr 2016 21:52:16 GMT


> On April 12, 2016, 11:10 p.m., Alex Naparu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 383
> > <https://reviews.apache.org/r/46013/diff/2/?file=1339790#file1339790line383>
> >
> >     Can you document this flag a bit please? GetProcessTimes requires PROCESS_QUERY_LIMITED_INFORMATION,
while GetProcessMemoryInfo requires the additional PROCESS_VM_READ.
> 
> Alex Clemmer wrote:
>     Sure, but what part would you like me to document?

I would like to see some explanatory note as to why the THREAD_ALL_ACCESS flag is required
(and appropriate) in this context. Looking at MSDN, none of the functions that are using the
process handle (GetProcessTimes and GetProcessMemoryInfo) make any note of this flag. It might
be that THREAD_ALL_ACCESS is overkill in this context.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46013/#review128565
-----------------------------------------------------------


On April 13, 2016, 9:49 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46013/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 9:49 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4471
>     https://issues.apache.org/jira/browse/MESOS-4471
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Implemented `os::processes` on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520

>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp edaa76a5322d0bf60b7172405aa754b5aca95458

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp c48106e5905e3be0faeba7177ef534766089faff

> 
> Diff: https://reviews.apache.org/r/46013/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message