mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 45214: Updated protobuf to support external storage.
Date Wed, 13 Apr 2016 21:42:07 GMT


> On 四月 13, 2016, 9:35 p.m., James DeFelice wrote:
> > include/mesos/mesos.proto, line 1625
> > <https://reviews.apache.org/r/45214/diff/7/?file=1342278#file1342278line1625>
> >
> >     I definitely prefer this form, but there's also a Parameters message type. Which
is more idiomatic in this context?

I saw that no one in protobuf is using this, and the `Parameters` is just a wrapper of `repeated
Parameter parameter`, I think it is OK to use `repeated Parameter parameter` here, comments?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45214/#review128751
-----------------------------------------------------------


On 四月 13, 2016, 3:09 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45214/
> -----------------------------------------------------------
> 
> (Updated 四月 13, 2016, 3:09 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5012
>     https://issues.apache.org/jira/browse/MESOS-5012
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated protobuf to support external storage.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 1232bcda053db3451d18413e81e54e51774f7f22 
>   include/mesos/v1/mesos.proto 1048fae62733926b5e863a0c1629bba69e35e43b 
> 
> Diff: https://reviews.apache.org/r/45214/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message