mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 46028: Improved comments in SocketManager::next().
Date Mon, 11 Apr 2016 23:52:15 GMT


> On April 11, 2016, 10:42 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/src/process.cpp, lines 1947-1954
> > <https://reviews.apache.org/r/46028/diff/1/?file=1339343#file1339343line1947>
> >
> >     The implication of this comment (regardless of your changes) seems to be that
the socket is an outbound socket? Is that true?

This function is called for both inbound and outbound sockets, and AFAICS similar comments
would apply (i.e., calling `shutdown()` means that any `recv` callback will see EOF on the
socket). Updated the comment accordingly.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46028/#review128267
-----------------------------------------------------------


On April 11, 2016, 2:35 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46028/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 2:35 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved comments in SocketManager::next().
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 
> 
> Diff: https://reviews.apache.org/r/46028/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message