mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 46030: Used initializer_list for collections in libprocess tests.
Date Mon, 11 Apr 2016 21:31:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46030/#review128255
-----------------------------------------------------------


Fix it, then Ship it!




Hm.. ideally there should not have been a TODO in the firewall tests, since it tends to just
serve as a distraction.


3rdparty/libprocess/src/tests/future_tests.cpp (lines 469 - 474)
<https://reviews.apache.org/r/46030/#comment191671>

    I tend to find an added `=` a little more clear, since it then reads as assignment to
an initializer list.


- Ben Mahler


On April 11, 2016, 9:01 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46030/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 9:01 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used initializer_list for collections in libprocess tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/future_tests.cpp c2eeb0e52dab08f390ec524ed727dde1a72916b3

>   3rdparty/libprocess/src/tests/process_tests.cpp e8ee8ee01ee9524b308452c403326e10f75b3ce5

> 
> Diff: https://reviews.apache.org/r/46030/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message