mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 45984: Fixed the commit message hook to wrap the variables in quotes.
Date Mon, 11 Apr 2016 16:48:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45984/#review128158
-----------------------------------------------------------


Ship it!





support/hooks/commit-msg (lines 26 - 27)
<https://reviews.apache.org/r/45984/#comment191521>

    Not part of this patch, but since we `wc` here we manually need to correct for it counting
the newline implicit in the use of `echo` (I am not entirely convinced by the argument here:
https://reviews.apache.org/r/45768/#review127198).
    
    Following @haosdent's original suggestion of just using shell builtins would not only
entirely have eliminated the problem this patch here fixes, but also have led to the same
magic max line length number appearing in both the check and the diagnostic.
    
        LENGTH=${#LINE}
        if [ "$LENGTH" -gt "72" ]; then
            echo >&2 "Error: No line in the commit message summary may exceed 72 characters."
        fi


- Benjamin Bannier


On April 10, 2016, 8:41 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45984/
> -----------------------------------------------------------
> 
> (Updated April 10, 2016, 8:41 a.m.)
> 
> 
> Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-5162
>     https://issues.apache.org/jira/browse/MESOS-5162
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/hooks/commit-msg d3f10c886a654aa8d8364faddf2e50dc7fe82058 
> 
> Diff: https://reviews.apache.org/r/45984/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message