mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 43471: Add the zookeeper patch for the allow add_auth calls.
Date Sun, 10 Apr 2016 10:24:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43471/
-----------------------------------------------------------

(Updated April 10, 2016, 10:24 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
-------

Update description.


Bugs: MESOS-4648
    https://issues.apache.org/jira/browse/MESOS-4648


Repository: mesos


Description (updated)
-------

Currently zookeeper multi-threaded c client doesn't wake up the IO
thread after enqueue auth info message. So the auth info message isn't
flushed util poll timeout. We back port this patch from ZOOKEEPER-770
to wake up the IO thread in send_info_packet() just as send_ping()
does.


Diffs (updated)
-----

  3rdparty/zookeeper-06d3f3f.patch 56480d5f42b65b5b75e40e5e44666f1db3cf2423 
  3rdparty/zookeeper-3.4.8.patch 486df1ae96af3426835c9d47ff2e36dd47ccde3f 

Diff: https://reviews.apache.org/r/43471/diff/


Testing
-------

Before

```
[       OK ] ZooKeeperMasterContenderDetectorTest.NonRetryableFrrors (10053 ms)
[       OK ] MasterZooKeeperTest.MasterInfoAddress (11282 ms)
[       OK ] ZooKeeperTest.Auth (6688 ms)
[       OK ] ZooKeeperTest.Create (6690 ms)
```

After

```
[       OK ] ZooKeeperMasterContenderDetectorTest.NonRetryableFrrors (321 ms)
[       OK ] MasterZooKeeperTest.MasterInfoAddress (447 ms)
[       OK ] ZooKeeperTest.Auth (233 ms)
[       OK ] ZooKeeperTest.Create (275 ms)
```


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message