mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 44427: Added --http_command_executor flag.
Date Sat, 09 Apr 2016 13:37:53 GMT


> On April 8, 2016, 11:29 p.m., Anand Mazumdar wrote:
> > src/slave/slave.cpp, line 5640
> > <https://reviews.apache.org/r/44427/diff/1/?file=1281966#file1281966line5640>
> >
> >     We typically don't spill partial arguments from a function invocation.
> >     
> >     How about:
> >     
> >     ```cpp
> >     executorPath = os::realpath(
> >       path::join(slave->flags.launcher_dir, ..));
> >     ```
> 
> Qian Zhang wrote:
>     Agree, but I think it should 4 space indent, see the followings as example:
>     https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L5901:L5902
>     https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L5955:L5956

Yep, was a bad copy paste typo on my part. Thanks for noticing it and updating the patch with
the correct fix!


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44427/#review127910
-----------------------------------------------------------


On April 9, 2016, 8:47 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44427/
> -----------------------------------------------------------
> 
> (Updated April 9, 2016, 8:47 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
>     https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added --http_command_executor flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md ba00ec563c449345effb3114111812601addcfc2 
>   src/slave/flags.hpp 300db49100d989d6c0409766b1341cb956ea1631 
>   src/slave/flags.cpp dd7bc9a48dfd8481336a2d2ec0beecd19a342644 
>   src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
> 
> Diff: https://reviews.apache.org/r/44427/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message