mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 45854: Updated the default JSON representation of a Resource to include GPUs.
Date Fri, 08 Apr 2016 05:54:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45854/
-----------------------------------------------------------

(Updated April 8, 2016, 5:54 a.m.)


Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.


Changes
-------

Updated some of the tests that rely on parsing the default Resource JSON. In the first iteratio,
some tests were failing without this:
```
[  FAILED  ] DynamicWeightsTest.PutInvalidRequest
[  FAILED  ] DynamicWeightsTest.ZeroWeight
[  FAILED  ] DynamicWeightsTest.NegativeWeight
[  FAILED  ] DynamicWeightsTest.NonNumericWeight
[  FAILED  ] DynamicWeightsTest.MissingRole
[  FAILED  ] DynamicWeightsTest.UnknownRole
[  FAILED  ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
[  FAILED  ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
[  FAILED  ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
[  FAILED  ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
[  FAILED  ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
[  FAILED  ] DynamicWeightsTest.RecoveredWeightsFromRegistry
[  FAILED  ] RoleTest.EndpointEmpty
[  FAILED  ] RoleTest.EndpointNoFrameworks
[  FAILED  ] RoleTest.EndpointImplicitRolesWeights
[  FAILED  ] RoleTest.EndpointImplicitRolesQuotas
[  FAILED  ] HTTPTest.ModelTask
[  FAILED  ] HTTPTest.ModelResources
[  FAILED  ] HTTP.ModelRoleResources
```

I must have missed these the first time around because I ran `make check` with a filter set.


Bugs: MESOS-5136
    https://issues.apache.org/jira/browse/MESOS-5136


Repository: mesos


Description (updated)
-------

This includes updating some tests that parse this JSON and look for
specific values for all of its fields.


Diffs (updated)
-----

  src/common/http.cpp 3748c71686c696c47f93a81e3434bbb55448e334 
  src/tests/common/http_tests.cpp ac6322d7fb58adf7a615c517496d08dee3bf0081 
  src/tests/dynamic_weights_tests.cpp e36a45fa18d163430df1c9dc72d2372aee9b44e6 
  src/tests/role_tests.cpp 056359bbe6a02bb129bfa2ce371e82cd3aa4c984 

Diff: https://reviews.apache.org/r/45854/diff/


Testing
-------

make check


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message