mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.
Date Thu, 07 Apr 2016 22:13:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44606/#review127678
-----------------------------------------------------------


Fix it, then Ship it!





docs/persistent-volume.md (line 296)
<https://reviews.apache.org/r/44606/#comment191068>

    Replace "Returns `202 ACCEPTED` which" with "This endpoint returns the `202 ACCEPTED`
HTTP status code, which " -- here and below.



docs/upgrades.md (line 167)
<https://reviews.apache.org/r/44606/#comment191061>

    Replace "return code" with "HTTP status code"
    
    I think you can just remove "which may introduce backwards incompatibility issue" (if
we're keeping it, the grammar isn't quite right).


- Neil Conway


On April 7, 2016, 8:56 a.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44606/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Neil Conway, Qian Zhang, and Vinod Kone.
> 
> 
> Bugs: mesos-4580
>     https://issues.apache.org/jira/browse/mesos-4580
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modify the return code of the following endpoints to 202:
> 1. /reserve
> 2. /unreserve
> 3. /create-volumes
> 4. /destroy-volumes
> 
> [#MESOS-4580]
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 4553465cc3dc17956f168469d405f7a453d6359e 
>   docs/endpoints/master/create-volumes.md 52ae3a8159bb7d26b63f5889ce3f122371afbdc4 
>   docs/endpoints/master/destroy-volumes.md a0bb1e8d1ce42ab2b96518cd4d325bfc541ad4ff 
>   docs/endpoints/master/reserve.md 1d481b56d380d45218001513330b225ca4a0a55c 
>   docs/endpoints/master/unreserve.md b9282df659ebb6090ef49ef8fc0f01411cd53103 
>   docs/persistent-volume.md ab6ed8227259384261dd5f7c2e353753f20e5c19 
>   docs/reservation.md 75357206085848826b70c2d6f2be93d20e771604 
>   docs/upgrades.md 64c6a02dd54ddf06c557b38e08916dc10e484cdd 
>   src/master/http.cpp f781fd0102c247b2e77a71f7be82b872b0831681 
>   src/tests/persistent_volume_endpoints_tests.cpp 9b8ad34469c0c9a986aa60f3a52584a3a9eabb2b

>   src/tests/reservation_endpoints_tests.cpp 2e0f6c1aba95d918b8c42219ee97f79f1070d56e

> 
> Diff: https://reviews.apache.org/r/44606/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message