mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhou xing <>
Subject Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.
Date Thu, 07 Apr 2016 07:10:45 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated 四月 7, 2016, 7:10 a.m.)

Review request for mesos, Kevin Klues and Vinod Kone.


change the code according to kevin's comments, also, added the uninstall hook

Summary (updated)

Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

Bugs: MESOS-3782

Repository: mesos

Description (updated)

In this patch, we did the following changes:
1. Duplicate executable file 'mesos-slave' with 'mesos-agent'
2. Rename the scripts in folder 'mesos/bin' & 'mesos/src/deploy'
to use term 'agent' instead of term 'slave'
3. Change the content of ths scripts to use term 'agent' instead
of term 'slave'
4. Duplicate the renamed scripts renamed in #2 during the configure
and make process, the duplicated scripts still use term 'slave'
in their names.

Diffs (updated)

  bin/ dbeec8464b26bd808f7a50b8412a2778f1458f22 
  bin/ 896c411b2b05d3c4a14288002520a5391a88d955 
  bin/ ab5b6c8bd8847485c5a47d637c9f4fe88c59ae65 
  bin/ 1e3b748ed4dc32ba6bd8adece20f439bce38abc3 
  bin/ 900c5883d96cf14e121e566bcf1ad4dc9a47abf6 c693b825294f82ace8a14563cf2229820e159e3c 
  src/ 71c4308cccfa5c56b93f6c3928dd2a1cf3ba9741 
  src/deploy/ bea5584fbcc68825b1c35b370aed17b0e432edd5 
  src/deploy/ 31567d6a47e19385aed56edfc7e67457c8cdde3e 
  src/deploy/ f7a003d9a8e5bbb4f11353988e55e715da0b2b4f 
  src/deploy/ 50860f40e33fcbb1787be6c035873de4bcc83de5 
  src/deploy/ e5f8c1fb400c56715774889632aa74d9eac33645 
  src/deploy/ 3dd9b51edff2beb3ccc8d5dd44f0cdc265f623f9 



make check


zhou xing

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message