mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fan du <fan...@intel.com>
Subject Re: Review Request 45808: Update metrics for SUBSCRIBE call for both PID/HTTP frameworks.
Date Thu, 07 Apr 2016 02:25:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45808/
-----------------------------------------------------------

(Updated 四月 7, 2016, 2:25 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
-------

Fixup coding style by dressing braces for if and else blocks


Bugs: MESOS-4981
    https://issues.apache.org/jira/browse/MESOS-4981


Repository: mesos


Description
-------

This change will cover three cases:
1. Directly call {re}registerFramework
2. Through HTTP call
3. Through MesosSchedulerDriver

Suggested by Benjamin Mahler to introspect framework_info.id.


Diffs (updated)
-----

  src/master/master.cpp 2cfa5075991bbb5df8a7e33b14767de558bda4ac 

Diff: https://reviews.apache.org/r/45808/diff/


Testing
-------

1. I can use 'docker-no-executor-framework' to reproduce/verify the issue.

"master/messages_register_framework": 1.0,
"master/messages_reregister_framework": 0.0,


Thanks,

fan du


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message