mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.
Date Thu, 07 Apr 2016 01:50:14 GMT


> On April 6, 2016, 5 p.m., haosdent huang wrote:
> > src/launcher/http_command_executor.cpp, line 264
> > <https://reviews.apache.org/r/44424/diff/6/?file=1325941#file1325941line264>
> >
> >     May you add a comment why need add `Second(1)` here?
> 
> Anand Mazumdar wrote:
>     It's pretty self-explanatory that it's the backoff retry timeout. No need for an
explicit comment.

hmm, let me drop this.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44424/#review127368
-----------------------------------------------------------


On April 5, 2016, 12:36 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44424/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 12:36 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
>     https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated http_command_executor.cpp to use v1 API.
> 
> 
> Diffs
> -----
> 
>   src/launcher/http_command_executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44424/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message