mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Re: Review Request 44545: Separated standalone and zookeeper classes.
Date Wed, 06 Apr 2016 22:53:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44545/#review127492
-----------------------------------------------------------


Ship it!




Ship It!

- Kapil Arya


On April 6, 2016, 12:03 p.m., Anurag Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44545/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 12:03 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-4610
>     https://issues.apache.org/jira/browse/MESOS-4610
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of keeping standalone and zookeper contender/detector class
> definitions and implementations in the same file, separated them. Also
> made the necessary changes in users of class headers to point to the
> new locations.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 55d3b341361bed25f3aa966d77060c88be29e5b0 
>   src/local/local.cpp 0d980188f933a8d543af696d8addd7ca5855413e 
>   src/master/contender.hpp 3fd20f8e94daab349b76d8f5ecc87398a187a847 
>   src/master/contender.cpp 846f516edcc63affd05158e9e5235e6d97f67f15 
>   src/master/contender/contender.cpp PRE-CREATION 
>   src/master/contender/standalone.hpp PRE-CREATION 
>   src/master/contender/standalone.cpp PRE-CREATION 
>   src/master/detector.hpp eb5d2a90b60c629150ddf04acf00f0edca1ca723 
>   src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e 
>   src/master/detector/detector.cpp PRE-CREATION 
>   src/master/detector/standalone.cpp PRE-CREATION 
>   src/master/detector/zookeeper.hpp PRE-CREATION 
>   src/master/main.cpp 181bbcb1758c0e9b83ef46496e990ce3d8c2195c 
>   src/master/master.hpp e5b16f94fa5650b9db44cd7c975adeb5871e16f6 
>   src/slave/main.cpp dc3a2d2908ec08df60651dec6bf8eac651579cea 
>   src/tests/authentication_tests.cpp 8143cd7a22bbdbcd0fc613cb44eae8b55fd458e7 
>   src/tests/cluster.cpp eefc2fa55bca1ad6a53047046fa4f5996d5c3fef 
>   src/tests/containerizer/external_containerizer_test.cpp 5e2116355418f5a0716cfd1573bab48ba75df596

>   src/tests/containerizer/isolator_tests.cpp 7e16846e97e20a7ef058dd8ae4664fa1c554283d

>   src/tests/fault_tolerance_tests.cpp 67238876952bb9a694cb04722113417a4b4eb58d 
>   src/tests/gc_tests.cpp 68a789cc77b5f1a17b8d002900095b18b1794ddd 
>   src/tests/master_allocator_tests.cpp 9d74b9ed4b6a4c708f3a044a03ce631899acf4aa 
>   src/tests/master_authorization_tests.cpp 8b9b8991fbb8c5a5beb69416a9c4a4ef3525942d 
>   src/tests/master_contender_detector_tests.cpp 616a2c7316adc116071feaad95e3901ff66213ad

>   src/tests/master_slave_reconciliation_tests.cpp 988f1d46580ab5a707fe801824e24f94d4f50da7

>   src/tests/master_tests.cpp bb599c952128e80e71beb2686e8665e5554856bc 
>   src/tests/mesos.hpp 3b565b45f45c84aba42aa6fb29b21f8306c49861 
>   src/tests/oversubscription_tests.cpp ba036810758d99a6fb0034c5e2bc7829e2343a44 
>   src/tests/partition_tests.cpp 349adbf67686e6044a2e6a4b673043ad74fce44e 
>   src/tests/persistent_volume_tests.cpp 47867505f2f1d7a722b5a0d4ff3a0fca3188a193 
>   src/tests/reconciliation_tests.cpp 5f2a35efe039da41992057c50e0319c6827f8d22 
>   src/tests/reservation_tests.cpp a9261bdf48c0af933e7fc303b7af356a60b49506 
>   src/tests/scheduler_event_call_tests.cpp 00e99777ba0294c9c12ac86594987afbd9388b51 
>   src/tests/scheduler_http_api_tests.cpp b65790a9aad0ca68c6a93dd1d872442b906598fd 
>   src/tests/scheduler_tests.cpp 0c66f65825a1fff01774bf0d94b08b9c22b1fbda 
>   src/tests/slave_recovery_tests.cpp 0d59a06f8e32f3d88f6c3a222bc6756a889a142e 
>   src/tests/slave_tests.cpp 57fc50360eae85819ae6ce714b0c3c4c1867b2b8 
> 
> Diff: https://reviews.apache.org/r/44545/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/44670/.
> 
> 
> Thanks,
> 
> Anurag Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message