mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 45839: Fixed commit message hook to not lint the diff in verbose mode.
Date Wed, 06 Apr 2016 22:23:36 GMT


> On April 6, 2016, 10:21 p.m., Kevin Klues wrote:
> > Ship It!

My only comment would be to add a comment about what this line is doing.  It's not obvious
that this is the delimiter used in verbose mode.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45839/#review127476
-----------------------------------------------------------


On April 6, 2016, 9:46 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45839/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 9:46 p.m.)
> 
> 
> Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-5132
>     https://issues.apache.org/jira/browse/MESOS-5132
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/hooks/commit-msg b32ee92da7ced33aea60ed4a02b2b98d3611fb9a 
> 
> Diff: https://reviews.apache.org/r/45839/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message