mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 45596: Updated docker containerizer private registry doc.
Date Wed, 06 Apr 2016 17:35:10 GMT


> On April 2, 2016, 8:20 p.m., Guangya Liu wrote:
> > docs/docker-containerizer.md, line 68
> > <https://reviews.apache.org/r/45596/diff/1/?file=1322512#file1322512line68>
> >
> >     What about 
> >     
> >     Rename `.docker/config.json` to `~/.docker/config.json`
> >     Rename `.dockercfg` to `~/.dockercfg`
> >     
> >     Or clarify that it should be in `HOME` dir, such as s/on each slave/on each
slave `HOME` directory

If we are using the flag pointing to a docker config file, the file is not necessary to locate
at HOME direcoty.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45596/#review126711
-----------------------------------------------------------


On April 6, 2016, 10:33 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45596/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 10:33 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated docker containerizer private registry doc.
> 
> 
> Diffs
> -----
> 
>   docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
> 
> Diff: https://reviews.apache.org/r/45596/diff/
> 
> 
> Testing
> -------
> 
> Tested by buidling with support/site-docker, and verified in web browser.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message