mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 45800: Moved long running framework to use the v1 API.
Date Wed, 06 Apr 2016 17:10:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45800/#review127365
-----------------------------------------------------------



LGTM.


src/examples/long_lived_framework.cpp (lines 216 - 220)
<https://reviews.apache.org/r/45800/#comment190648>

    Would be nice to log something here.



src/examples/long_lived_framework.cpp (line 590)
<https://reviews.apache.org/r/45800/#comment190652>

    Does the HTTP scheduler driver initialize glog (like the old scheduler driver does)?


- Joseph Wu


On April 5, 2016, 8:43 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45800/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 8:43 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
>     https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary. Also removed the AuthN code. Once, the library
> supports AuthN we can bring it back.
> 
> 
> Diffs
> -----
> 
>   src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 
> 
> Diff: https://reviews.apache.org/r/45800/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message