mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 45804: Added a path to the upgrade test script.
Date Wed, 06 Apr 2016 07:52:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45804/#review127298
-----------------------------------------------------------


Ship it!




Let's add a JIRA ticket to description, so that "the next" guy will save some time.

Also, I dream of cross-platform helper functions that will allow us to define things like
helper directory once, i.e. being able to call `getTestScriptPath()` from this python helper...

- Alexander Rukletsov


On April 6, 2016, 5:25 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45804/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 5:25 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In Mesos 0.28.0, the `MESOS_BUILD_DIR` environment variable in the test framework was
changed to `MESOS_HELPER_DIR`, and the location of the path was altered. This patch updates
the upgrade script to accommodate both environment variables.
> 
> 
> Diffs
> -----
> 
>   support/test-upgrade.py 99c8e7656dc2a2f54a309d4a369e73ca2ab2f4dd 
> 
> Diff: https://reviews.apache.org/r/45804/diff/
> 
> 
> Testing
> -------
> 
> Used `support/test-upgrade.py --prev="/path/to/0.27.2" --next="/path/to/0.28.1-rc2"`
to test.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message