mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.
Date Sun, 03 Apr 2016 14:22:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44823/#review126728
-----------------------------------------------------------




src/slave/containerizer/docker.cpp (lines 785 - 788)
<https://reviews.apache.org/r/44823/#comment189785>

    const ExecutorInfo& executorInfo = recoverable.executor_info();
    const ContainerID& containerId = recoverable.container_id();
    const FrameworkID& frameworkId = executorInfo.framework_id();
    const ExecutorID& executorId = executorInfo.executor_id();



src/slave/containerizer/docker.cpp (lines 790 - 791)
<https://reviews.apache.org/r/44823/#comment189786>

    I think that here should be `||` but not `&&`



src/slave/containerizer/docker.cpp (lines 790 - 803)
<https://reviews.apache.org/r/44823/#comment189787>

    I think that this logic can make the code more clear:
    
    if (!existingContainers.contains(containerId)) {
      xxx;
      continue;
    }
    
    if (!executorInfo.has_container()) {
      xxx;
      continue;
    }
    
    if (executorInfo.container().type() != ContainerInfo::DOCKER) {
      xxxx;
      continue;
    }


- Guangya Liu


On 四月 3, 2016, 2:11 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44823/
> -----------------------------------------------------------
> 
> (Updated 四月 3, 2016, 2:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ian Downes, Jie Yu, Till Toenshoff, and Timothy
Chen.
> 
> 
> Bugs: MESOS-5085
>     https://issues.apache.org/jira/browse/MESOS-5085
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Remove `SlaveState` in `DockerContainerizer` during recover.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.hpp 89d450e10a84f24ddd46d517e2b4b46ab02c4fda 
>   src/slave/containerizer/docker.cpp 9314d1f9e0b6077fe7c48b860783ab21acc48be6 
>   src/tests/containerizer/docker_containerizer_tests.cpp b9c26b92c44e8ca718a5eb333855199bdf2a8e81

> 
> Diff: https://reviews.apache.org/r/44823/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message