mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.
Date Sun, 03 Apr 2016 14:08:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44798/#review126726
-----------------------------------------------------------




src/slave/containerizer/containerizer.hpp (line 29)
<https://reviews.apache.org/r/44798/#comment189784>

    what is the use of this include for this patch?



src/slave/slave.cpp (line 4694)
<https://reviews.apache.org/r/44798/#comment189779>

    I know that those code are copied from `MesosContainerizerProcess::recover`, but it is
better update the comments a bit.
    
    s/run states/run-time status


- Guangya Liu


On 四月 3, 2016, 1:06 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44798/
> -----------------------------------------------------------
> 
> (Updated 四月 3, 2016, 1:06 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-3709
>     https://issues.apache.org/jira/browse/MESOS-3709
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update `Slave::_recoverContainerizer` to use `ContainerState`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.hpp ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf

>   src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa 
> 
> Diff: https://reviews.apache.org/r/44798/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message