mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <>
Subject Re: Review Request 44993: Updated `TestContainerizer` to support default actions.
Date Thu, 24 Mar 2016 17:30:01 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 24, 2016, 5:30 p.m.)

Review request for mesos and Ben Mahler.

Repository: mesos


We use `ON_CALL` and `WillByDefault` here to specify the default
actions. This allows the tests to leverage the `DoDefault` action.
However, `ON_CALL` results in a "Uninteresting mock function call"
warning unless each test puts expectations in place. As a result,
we also use `EXPECT_CALL` and `WillRepeatedly` to get the best of
both worlds: the ability to use `DoDefault` and no warnings when
expectations are not explicit.


  src/tests/containerizer.cpp c6772ce5908edaab6c3189a65e8446217d1c7c27 



On Mac OS 10.10.4:
`make check`
`GTEST_FILTER="SlaveTest.*" ./bin/ --gtest_repeat=100 --gtest_break_on_failure`


Alexander Rukletsov

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message