mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 45040: Added a test for task's kill policy.
Date Tue, 22 Mar 2016 10:27:22 GMT


> On March 19, 2016, 1:35 a.m., Ben Mahler wrote:
> > Thanks for the test! Although I wouldn't want to ship this unless you show some
manual testing in the 'testing done' section, since this test doesn't exercise the functionality
:)

I think since we pulled up half of the test into a separate test, we don't need this one any
more. I'll discard the review request.


> On March 19, 2016, 1:35 a.m., Ben Mahler wrote:
> > src/tests/slave_tests.cpp, lines 3419-3424
> > <https://reviews.apache.org/r/45040/diff/1/?file=1306241#file1306241line3419>
> >
> >     You won't need to bother with this once we pull out the validation test, right?

Correct.


> On March 19, 2016, 1:35 a.m., Ben Mahler wrote:
> > src/tests/slave_tests.cpp, lines 3442-3444
> > <https://reviews.apache.org/r/45040/diff/1/?file=1306241#file1306241line3442>
> >
> >     You shouldn't need to do this once the validation test is pulled out, right?

Right.


> On March 19, 2016, 1:35 a.m., Ben Mahler wrote:
> > src/tests/slave_tests.cpp, line 3482
> > <https://reviews.apache.org/r/45040/diff/1/?file=1306241#file1306241line3482>
> >
> >     Why the resume here?

I think we should resume the clock before exiting the test. I've heard plans to even add a
check in our test harness that verified the clock is not paused.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45040/#review124343
-----------------------------------------------------------


On March 19, 2016, 10:40 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45040/
> -----------------------------------------------------------
> 
> (Updated March 19, 2016, 10:40 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4909
>     https://issues.apache.org/jira/browse/MESOS-4909
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp ea1d776077bf638885db8421194aa4427c772169 
> 
> Diff: https://reviews.apache.org/r/45040/diff/
> 
> 
> Testing
> -------
> 
> On Mac OS 10.10.4:
> `make check`
> `GTEST_FILTER="*TaskKillPolicy*" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message