mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhiwei Chen <zhiw...@gmail.com>
Subject Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.
Date Tue, 22 Mar 2016 02:22:23 GMT


> On March 22, 2016, 7:21 a.m., Vinod Kone wrote:
> > 3rdparty/libprocess/src/decoder.hpp, lines 175-177
> > <https://reviews.apache.org/r/44372/diff/2/?file=1280497#file1280497line175>
> >
> >     Why do we need this now?

In http-parse >= 2.x, the url.fragement is None, the previous code did not catch this,
so I added it.

Actually, the previous code logic will not run this function because of the `#if (HTTP_PARSER_VERSION_MAJOR
>= 2)`.


- Zhiwei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44372/#review124679
-----------------------------------------------------------


On March 14, 2016, 10:01 p.m., Zhiwei Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44372/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 10:01 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod
Kone.
> 
> 
> Bugs: MESOS-4805
>     https://issues.apache.org/jira/browse/MESOS-4805
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Upgrade http-parser to 2.6.1 to support Power LE platform.
> 
> 
> Diffs
> -----
> 
>   3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt b8351ad0181d885a984580ae8de208ea0524b0e7

>   3rdparty/libprocess/3rdparty/Makefile.am ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 
>   3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch f9fac12437a6bedc66353fda1ce9c0d7a383225a

>   3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz b811b63ce0ad6d71d9d296fed76656c023c76fc5

>   3rdparty/libprocess/3rdparty/versions.am 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 
>   3rdparty/libprocess/src/decoder.hpp a20b5ba8fc50d834573d253948645cc863f030dd 
>   LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
> 
> Diff: https://reviews.apache.org/r/44372/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message