mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 44084: Windows: Forked os::rename().
Date Mon, 21 Mar 2016 19:24:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44084/#review124623
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp (lines 45 - 46)
<https://reviews.apache.org/r/44084/#comment187253>

    ```
        return WindowsError(
            "`os::rename` failed to move file '" + from + "' to '" + to + "'");
    ```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 192)
<https://reviews.apache.org/r/44084/#comment187238>

    Add newline.



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 213)
<https://reviews.apache.org/r/44084/#comment187241>

    ```
    ASSERT_EQ(2u, allFiles.get().size());
    ```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 216)
<https://reviews.apache.org/r/44084/#comment187239>

    ```
    s/that was in `file`/\that was in `file1`/
    ```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 217)
<https://reviews.apache.org/r/44084/#comment187244>

    "has gone down"? shouldn't this be: that the count of files in the directory has not changed..?



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 222)
<https://reviews.apache.org/r/44084/#comment187240>

    ```
    ASSERT_EQ(message, file3Contents.get());
    ```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 226)
<https://reviews.apache.org/r/44084/#comment187242>

    ```
    ASSERT_EQ(2u, allFiles.get().size());
    ```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 229)
<https://reviews.apache.org/r/44084/#comment187243>

    `s/cound/count/`



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 234)
<https://reviews.apache.org/r/44084/#comment187246>

    ```
    ASSERT_TRUE(0u, file2Contents.get());
    ```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 238)
<https://reviews.apache.org/r/44084/#comment187250>

    ```
    ASSERT_TRUE(1u, allFiles.get().size());
    ```



3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp (line 248)
<https://reviews.apache.org/r/44084/#comment187251>

    ```
    ASSERT_TRUE(1u, allFiles.get().size());
    ```


- Michael Park


On March 17, 2016, 11:59 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44084/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 11:59 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere,
Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Forked os::rename().
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 7bd4bfbc2ec5922879dcefddc12137336b11be52

>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 79e30ca04c6d23f92e3a2f80fbe38ae63fde3520

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rename.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rename.hpp 7b2215208bcaa5613426d8ede9cab21d1a084631

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rename.hpp PRE-CREATION

>   3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 4c30189bb8261ccfc699da0f31b8b1fd3e9b3c83

> 
> Diff: https://reviews.apache.org/r/44084/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message