mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.
Date Thu, 10 Mar 2016 17:42:45 GMT


> On March 10, 2016, 7:16 a.m., Adam B wrote:
> > src/master/http.cpp, lines 1166-1167
> > <https://reviews.apache.org/r/44583/diff/1/?file=1293356#file1293356line1166>
> >
> >     Why is the space removed here?
> >     Do we need to put a space after `JSON` instead?

TLDR processing inserts newlines automatically between strings; a space is not required after
'JSON', and isn't useful before 'and'. For reference, see how the other TLDR strings work.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44583/#review122889
-----------------------------------------------------------


On March 9, 2016, 6:04 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44583/
> -----------------------------------------------------------
> 
> (Updated March 9, 2016, 6:04 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Reran `generate-endpoint-help.py` script for `/weights` endpoint.
> 
> 
> Diffs
> -----
> 
>   docs/endpoints/index.md bd70819b186c33718f66830034979d415767a2a3 
>   docs/endpoints/master/weights.md PRE-CREATION 
>   src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df 
> 
> Diff: https://reviews.apache.org/r/44583/diff/
> 
> 
> Testing
> -------
> 
> Previewed via site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message