mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 44523: Changed the master's default HTTP authentication realm.
Date Thu, 10 Mar 2016 04:02:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44523/#review122874
-----------------------------------------------------------



I just did a grep and I found this:

```sh
$ ag --cpp --ignore="build/.*" '\"mesos\"' .
# ...
src/authentication/http/basic_authenticator_factory.cpp
66:  Authenticator* authenticator = new BasicAuthenticator("mesos", credentials);

src/master/constants.hpp
136:// Name of the default, "mesos" HTTP authentication realm.
# ...
```

at least those two need to be changed.

- Alexander Rojas


On March 9, 2016, 9:42 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44523/
> -----------------------------------------------------------
> 
> (Updated March 9, 2016, 9:42 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4849
>     https://issues.apache.org/jira/browse/MESOS-4849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed the master's default HTTP authentication realm.
> 
> 
> Diffs
> -----
> 
>   src/master/constants.cpp e316f9772d880b694faeee6d001dc56bc088c118 
> 
> Diff: https://reviews.apache.org/r/44523/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message