mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 44289: Added support for contender and detector modules.
Date Fri, 04 Mar 2016 04:53:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44289/#review122016
-----------------------------------------------------------



Bad patch!

Reviews applied: [44289, 44288, 44287]

Failed command: ./support/apply-review.sh -n -r 44288

Error:
2016-03-04 04:53:33 URL:https://reviews.apache.org/r/44288/diff/raw/ [35333/35333] -> "44288.patch"
[1]
error: patch failed: include/mesos/v1/scheduler.hpp:81
error: include/mesos/v1/scheduler.hpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/11812/console

- Mesos ReviewBot


On March 3, 2016, 5:29 p.m., Anurag Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44289/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 5:29 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4610
>     https://issues.apache.org/jira/browse/MESOS-4610
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for contender and detector modules.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module/contender.hpp PRE-CREATION 
>   include/mesos/module/detector.hpp PRE-CREATION 
>   src/Makefile.am fe549a881e778e094d3f957e5119eeb2f55e7915 
>   src/examples/test_contender_module.cpp PRE-CREATION 
>   src/examples/test_detector_module.cpp PRE-CREATION 
>   src/local/local.cpp 359fc54d7c4081f536a8de8b1dfcde413d75c9a9 
>   src/master/contender.cpp 9ad49ce10439fb41d78d52eaa4c1e6b9c5c7f735 
>   src/master/detector.cpp 9274435802d6292b183be48f42b43999476e016e 
>   src/module/manager.cpp 6ae99504005581b22a44768949b1d305cec517d9 
>   src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 
>   src/tests/module.cpp 8cc305c0ef606b07eea39d548d3165a2bb2b042a 
> 
> Diff: https://reviews.apache.org/r/44289/diff/
> 
> 
> Testing
> -------
> 
> In addition to all unit tests passing, we are currently using this functionality in our
environment with a custom consensus stack. In our world, we have a C++ plugin that calls out
to an HTTP REST service (implemented in Java/Scala, not that it matters).
> 
> 
> Thanks,
> 
> Anurag Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message