mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 44370: Fixed incorrect http authenticator module type.
Date Fri, 04 Mar 2016 00:14:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44370/
-----------------------------------------------------------

(Updated March 4, 2016, 12:14 a.m.)


Review request for mesos and Alexander Rojas.


Repository: mesos


Description
-------

see summary.


Diffs
-----

  src/master/master.cpp 2be954d04ab9ba329bac95d815637caf557339cc 

Diff: https://reviews.apache.org/r/44370/diff/


Testing (updated)
-------

make check & functional testing

Modules definition:
```
--modules="libraries {
  file: "/somewhere/libtills_awesome_http_authenticator.dylib"
  modules {
    name: "tills_awesome_auth_module"
    parameters {
      key: "foo"
      value: "bar"
    }
  }
}
```

Before applying this patch.

Resulting in:
```
HTTP authenticator 'tills_awesome_auth_module' not found. Check the spelling (compare to 'basic'')
or verify that the authenticator was loaded successfully (see --modules)
```

After applying this patch, resulting in:
```
I0304 00:49:45.259122 1064960 master.cpp:555] Using 'tills_awesome_auth_module' HTTP authenticator
```


Thanks,

Till Toenshoff


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message