mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 44275: Fixed flakiness in tests using the scheduler library.
Date Fri, 04 Mar 2016 00:03:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44275/
-----------------------------------------------------------

(Updated March 4, 2016, 12:03 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Review comments from Vinod to add more comments to the destructor.


Bugs: MESOS-4029
    https://issues.apache.org/jira/browse/MESOS-4029


Repository: mesos


Description
-------

This change fixes the tests using the scheduler library by
explicitly invoking `stop()` from the testing interface. This
ensures that no further callbacks are delivered to the scheduler.

For one-off async callbacks that are already on the libprocess queue
we need to do a `Clock::settle` to ensure they are executed before
the mock object goes out of scope.


Diffs (updated)
-----

  src/tests/mesos.hpp 1d4f075e470a60040e17b9f011aea6202310c437 

Diff: https://reviews.apache.org/r/44275/diff/


Testing
-------

make check + Induced a sleep in the async callbacks. Previously, the test used to crash but
with the fix it no longer crashes.


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message