mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.
Date Thu, 03 Mar 2016 22:26:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44287/#review121946
-----------------------------------------------------------




include/mesos/master/contender.hpp (line 43)
<https://reviews.apache.org/r/44287/#comment183799>

    I'm going to reiterate this comment (https://reviews.apache.org/r/43269/#comment181059).
    
    For modules, the "type" is some string that identifies the entry point of the entry. 
To be backwards compatible and support modules, you will need either 2 arguments or 2 separate
factory methods (or some really ugly logic inside the factory method).



include/mesos/master/detector.hpp (line 40)
<https://reviews.apache.org/r/44287/#comment183800>

    Same comment as above.


- Joseph Wu


On March 3, 2016, 9:29 a.m., Anurag Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44287/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 9:29 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4610
>     https://issues.apache.org/jira/browse/MESOS-4610
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MasterContender and MasterDetector abstract classes can be subclassed by
> user-provided classes to allow for arbitrary contender/detector implementations.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/contender.hpp PRE-CREATION 
>   include/mesos/master/detector.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44287/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/44289/.
> 
> 
> Thanks,
> 
> Anurag Singh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message