mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 44357: Added check for Appc image's dependency id.
Date Thu, 03 Mar 2016 21:20:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44357/#review121939
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On March 3, 2016, 8:42 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44357/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 8:42 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since dependency's image id is an optional field, we need to check for its
> existence before using it for fetching an image.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 1e893daa63d48d4290bf4c4e8655ca3f39133c3e

> 
> Diff: https://reviews.apache.org/r/44357/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message