mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yongqiao Wang <yq...@cn.ibm.com>
Subject Re: Review Request 43806: Add comments for rebalance.
Date Thu, 03 Mar 2016 13:47:50 GMT


> On March 2, 2016, 2:07 p.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1066-1069
> > <https://reviews.apache.org/r/43806/diff/2/?file=1272996#file1272996line1066>
> >
> >     For posterity, we backtick types and variables names.
> 
> Yongqiao Wang wrote:
>     Do you mean we should update the comment to :
>     
>         // The allocator only needs to 'rebalance' if there is a framework
>         // registered with this role. The 'roleSorter' contains only roles
>         // for registered frameworks, but 'quotaRoleSorter' contains any role
>         // with quota set, regardless of whether any frameworks are registered
>         // with that role.
> 
> Alexander Rukletsov wrote:
>     First, I didn't mean to include "rebalance" because it is a proper English word in
this context. Second, I meant backticks ` and not single quotes '. Third, I don't think we
should start another review to fix it, but let's avoid it in the future.

OK, I see. Thanks!


- Yongqiao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43806/#review121641
-----------------------------------------------------------


On Feb. 27, 2016, 12:26 p.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43806/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2016, 12:26 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-3943
>     https://issues.apache.org/jira/browse/MESOS-3943
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add comments for rebalance.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 1b69fa801cd3f08cfcdce71ee3a3ca266b2fde57

> 
> Diff: https://reviews.apache.org/r/43806/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message