mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.
Date Thu, 03 Mar 2016 13:36:41 GMT


> On March 2, 2016, 12:37 p.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/metrics.hpp, line 23
> > <https://reviews.apache.org/r/44260/diff/1/?file=1276467#file1276467line23>
> >
> >     s/</"
> >     s/>/"
> >     
> >     We use <> only for "library" or public includes: libprocess, stout, mesos,
etc
> 
> Alexander Rukletsov wrote:
>     Why did you drop the issue?

Sorry, misclicked, is fixed.


> On March 2, 2016, 12:37 p.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/metrics.hpp, line 43
> > <https://reviews.apache.org/r/44260/diff/1/?file=1276467#file1276467line43>
> >
> >     Is it what clnag-format suggest? I doubt it : )
> 
> Benjamin Bannier wrote:
>     Yes, that's indeed what it suggests, at least with what is defined as `Google` style
in clang trunk.
> 
> Alexander Rukletsov wrote:
>     We don't use Google style, but rather the one living in our source: https://mesos.apache.org/documentation/latest/clang-format/

Note that the code is fixed.

In fact we blindly inherit whatever clang-format has backed in as `Google` style, https://github.com/apache/mesos/blob/master/support/clang-format#L2.
This an issue if one uses a different version of clang-format than the one used when the Mesos
style was written down, like I do here.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44260/#review121624
-----------------------------------------------------------


On March 3, 2016, 2:11 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44260/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 2:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4718
>     https://issues.apache.org/jira/browse/MESOS-4718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am b30cc25f61856d6417437547baaa0bb338a30d63 
>   src/master/allocator/mesos/hierarchical.hpp 3043888630b066505410d3b32c5b3f813cc458c1

>   src/master/allocator/mesos/metrics.hpp PRE-CREATION 
>   src/master/allocator/mesos/metrics.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44260/diff/
> 
> 
> Testing
> -------
> 
> `make distcheck` on OS X.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message