mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 44290: Added tests involving HTTP scheduler stream IDs.
Date Thu, 03 Mar 2016 01:41:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44290/#review121764
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/scheduler_http_api_tests.cpp (line 899)
<https://reviews.apache.org/r/44290/#comment183582>

    // Send a TEARDOWN call without stream ID.



src/tests/scheduler_http_api_tests.cpp (line 1039)
<https://reviews.apache.org/r/44290/#comment183583>

    nice test!


- Vinod Kone


On March 2, 2016, 10:20 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44290/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 10:20 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3583
>     https://issues.apache.org/jira/browse/MESOS-3583
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests involving HTTP scheduler stream IDs.
> 
> Three new tests have been added in this patch: SchedulerHttpApiTest.TeardownWithoutStreamId,
SchedulerHttpApiTest.TeardownWrongStreamId, and SchedulerHttpApiTest.SubscribeWithStreamId.
> 
> 
> Diffs
> -----
> 
>   src/tests/scheduler_http_api_tests.cpp 428e12646d80b45daec30cfe607b97f36170fdf5 
> 
> Diff: https://reviews.apache.org/r/44290/diff/
> 
> 
> Testing
> -------
> 
> `make check` was used to test on both OSX and CentOS 7.1
> 
> The new tests were run 1000 times to look for flakiness; no failures were observed.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message