mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 43914: Modified `NetClsHandleManager` to take a range of secondary handles.
Date Mon, 29 Feb 2016 22:58:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43914/#review121339
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (lines 125 - 127)
<https://reviews.apache.org/r/43914/#comment183022>

    I think you should be able to use `foreach` here



src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp (lines 166 - 168)
<https://reviews.apache.org/r/43914/#comment183024>

    Ditto on using foreach


- Jie Yu


On Feb. 24, 2016, 4:44 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43914/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 4:44 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4700
>     https://issues.apache.org/jira/browse/MESOS-4700
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `alloc`, `free` and `reserve` methods of `NetClsHandleManager` can
> now work with a specified range of secondary handles instead of
> assuming that the entire 64K space of secondary handles is available
> for use.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp acd61e615951e18dd51a2ce1e746ba733e9159ae

>   src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp f05cd55a9e080f44566ec7dcef22f11950496d6f

> 
> Diff: https://reviews.apache.org/r/43914/diff/
> 
> 
> Testing
> -------
> 
> make and make check.
> 
> Also ran sudo make check for the "NetClsIsolatoTest"
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message