mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 42719: Add doc for weights.
Date Sun, 28 Feb 2016 08:21:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42719/#review121129
-----------------------------------------------------------



Thanks! Couple of tweaks as I review it again.
- How did you test that this renders correctly? Did you try `support/site-docker` to see if
the markdown translates properly to html? Just because it looks good in github doesn't mean
our Rakefile will make it look as good.


docs/weights.md (line 7)
<https://reviews.apache.org/r/42719/#comment182768>

    "... priority among roles." - and link to roles.md.



docs/weights.md (line 9)
<https://reviews.apache.org/r/42719/#comment182769>

    s/via/by/



docs/weights.md (line 16)
<https://reviews.apache.org/r/42719/#comment182773>

    Are we officially deprecating --weights in this release? If so, we'll need to update upgrades.md
and the CHANGELOG to mention this.
    
    Could you also document what happens when a master restarts with a --weights flag that
differs from what's in the registry? (We warn and use the registry value, correct?)



docs/weights.md (line 32)
<https://reviews.apache.org/r/42719/#comment182770>

    s/example/example,/



docs/weights.md (line 48)
<https://reviews.apache.org/r/42719/#comment182771>

    s/the specified/all specified/



docs/weights.md (line 54)
<https://reviews.apache.org/r/42719/#comment182772>

    s/negative/non-positive/ (since 0 is also invalid)


- Adam B


On Feb. 18, 2016, 11:56 p.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42719/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 11:56 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3945
>     https://issues.apache.org/jira/browse/MESOS-3945
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add doc for weights.
> 
> 
> Diffs
> -----
> 
>   docs/home.md 07214b927c112d7a180507ae03245892455fd757 
>   docs/weights.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42719/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message