mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 43997: CMake: Move FindApr and FindSvn to master.
Date Fri, 26 Feb 2016 17:46:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43997/#review120900
-----------------------------------------------------------



Hmm, I think I might have missed the rationale for moving this. Let me fill in some blanks
and just explain why we put these scripts in the `3rdparty` directory to begin with.

The short explanation is that libprocess and stout are meant (at least in theory) to be managed
as _libraries_, and the result is that configuration scripts for those projects should be
completely self-contained inside them. So, in other words, if you'd like to use Stout or libprocess
(which have a dependency on SVN and APR) in the master or the slave, then an elegant way of
handling this would be to just point those binaries at the Stout/libprocess configuration
scripts, and have it just call them. The idea is, you shouldn't have to worry about `Find*.cmake`
files, you just need to call `StoutConfigure.cmake`.

Now, in this case, I think that the problem you are facing is that there exists a `StoutTestsConfigure.cmake`
that configures the Stout tests, but there is not simply `StoutConfigure.cmake`, which means
that both the master and the slave need to essentially roll their own Stout configuration.
This is not convenient!

Luckily for you, though, I've introduced a `StoutConfigure.cmake` in the following 3 commits:

https://reviews.apache.org/r/43697/
https://reviews.apache.org/r/43698/
https://reviews.apache.org/r/43699/

Do you think this addresses the problem you have? Let me know if you have any other concerns
or things I can help with.

- Alex Clemmer


On Feb. 25, 2016, 8:41 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43997/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2016, 8:41 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Joseph Wu.
> 
> 
> Bugs: MESOS-4773
>     https://issues.apache.org/jira/browse/MESOS-4773
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Move FindApr and FindSvn to master.
> 
> 
> Diffs
> -----
> 
>   src/master/cmake/FindApr.cmake PRE-CREATION 
>   src/master/cmake/FindSvn.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43997/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message