mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 43960: Added an end-to-end test for docker registry puller.
Date Fri, 26 Feb 2016 17:00:24 GMT


> On Feb. 24, 2016, 8:03 p.m., Jojy Varghese wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 361
> > <https://reviews.apache.org/r/43960/diff/1/?file=1268379#file1268379line361>
> >
> >     Would it add value if we assert that the store does not currently have the image?
> >     
> >     Also, have assertions around the image being placed in the right dircetory?

The MesosTest fixture will create a new slave work directory for each slave started. So this
is not needed.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43960/#review120565
-----------------------------------------------------------


On Feb. 24, 2016, 6:51 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43960/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 6:51 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an end-to-end test for docker registry puller.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp b3c6f8848f2ceb2bd4dce35d6e7f813c2d4d2bd9

> 
> Diff: https://reviews.apache.org/r/43960/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message