mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cong Wang <xiyou.wangc...@gmail.com>
Subject Re: Review Request 43461: Used C++11 for loop to iterate std list/set.
Date Thu, 25 Feb 2016 04:09:56 GMT


> On Feb. 24, 2016, 7:29 p.m., Michael Park wrote:
> > 3rdparty/libprocess/include/process/future.hpp, line 791
> > <https://reviews.apache.org/r/43461/diff/2/?file=1268386#file1268386line791>
> >
> >     * Mesos currently uses `foreach` from stout rather than range-based`for`.
> >     * Mesos generally prefers explicit types than `auto`.
> >     
> >     ```
> >     foreach (Future<T> future, futures) {
> >       ...
> >     }
> >     ```
> >     
> >     Here and below.
> 
> Cong Wang wrote:
>     Is that a strict rule? At least src/tests/hierarchical_allocator_tests.cpp uses for(auto...)
too.
> 
> Michael Park wrote:
>     Yeah, those shouldn't have made it into the codebase for consistency. The migration
strategy is being discussed/tracked here: [MESOS-3214](https://issues.apache.org/jira/browse/MESOS-3214).

OK. I will use foreach before we migrate to C++11 for loop.


- Cong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43461/#review120550
-----------------------------------------------------------


On Feb. 24, 2016, 7:19 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43461/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used C++11 for loop to iterate std list/set.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 77655f22ad4ce6e81fd46bcdebbf2a82786e8f49

> 
> Diff: https://reviews.apache.org/r/43461/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message